-
Notifications
You must be signed in to change notification settings - Fork 45
CAL: adding meeting links to SP learn meeting #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAL: adding meeting links to SP learn meeting #795
Conversation
✅ Deploy Preview for scientific-python-org ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one change to the hackmd URL. Thanks @bsipocz
Scientific Python. | ||
Meeting Link: https://washington.zoom.us/j/92404931842 | ||
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg?both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg?both | |
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg/edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the split view by default whether one is logged in or not 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok but you still need /edit
in the URL (surprised that it goes after the ?both
and not before... but I just tested it on a not-logged-in browser)
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg?both | |
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg?both/edit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, weird. I can edit it on the both link, without edit, when not logged into a private window, but have to click on edit with your link (no matter if it's the new or the old suggestion)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok well if it's working now (as it wasn't during the meeting) then please ignore my suggestion and just merge as-is. We can always revisit if it causes problems again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I can you just needed to republish it with adding access rights to everyone with the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just merge as-is
I can't just yet, we need someone else to review, too.
So we have nice links in the individual calendar entries such as we have for SPECs meeting: