Skip to content

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 19, 2025

So we have nice links in the individual calendar entries such as we have for SPECs meeting:

Screenshot 2025-08-19 at 09 13 48 Screenshot 2025-08-19 at 09 13 57

@bsipocz bsipocz requested a review from drammock August 19, 2025 16:15
Copy link

netlify bot commented Aug 19, 2025

Deploy Preview for scientific-python-org ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 18f34d6
🔍 Latest deploy log https://app.netlify.com/projects/scientific-python-org/deploys/68a4a3310534f80008f3c9b3
😎 Deploy Preview https://deploy-preview-795--scientific-python-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94
Accessibility: 100
Best Practices: 100
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one change to the hackmd URL. Thanks @bsipocz

Scientific Python.
Meeting Link: https://washington.zoom.us/j/92404931842
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg?both
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg?both
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg/edit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the split view by default whether one is logged in or not 🤷‍♀️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok but you still need /edit in the URL (surprised that it goes after the ?both and not before... but I just tested it on a not-logged-in browser)

Suggested change
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg?both
Meeting notes: https://hackmd.io/zVZtDmAvRduUY5zg0giMkg?both/edit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, weird. I can edit it on the both link, without edit, when not logged into a private window, but have to click on edit with your link (no matter if it's the new or the old suggestion)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok well if it's working now (as it wasn't during the meeting) then please ignore my suggestion and just merge as-is. We can always revisit if it causes problems again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I can you just needed to republish it with adding access rights to everyone with the link.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just merge as-is

I can't just yet, we need someone else to review, too.

@bsipocz bsipocz requested a review from jarrodmillman August 19, 2025 18:21
@stefanv stefanv merged commit 538bce5 into scientific-python:main Aug 27, 2025
5 checks passed
@bsipocz bsipocz deleted the CAL_adding_meeting_link_to_learn branch August 27, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants