Skip to content

Fix foldLeft and foldRight return types #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix foldLeft and foldRight return types #77

wants to merge 1 commit into from

Conversation

axlon
Copy link

@axlon axlon commented Aug 14, 2024

The following code is valid, but not allowed by template types currently. This PR fixes that.

$some = new Some(5);
$result = $some->foldLeft(1, function($a, $b) { return (string) ($a + $b) }); // string("6")

@ojhaujjwal
Copy link

@GrahamCampbell Can we get this merged please if all okay?

plus my PR too #78 around the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ojhaujjwal ojhaujjwal ojhaujjwal approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axlon @ojhaujjwal