Skip to content

Conversation

@Mia-Cross
Copy link
Contributor

@Mia-Cross Mia-Cross commented Oct 27, 2025

This PR starts the migration of tests cassettes from go-vcr.v3 to go-vcr.v4 with the instance package.
Both versions of go-vcr can coexist in the same go.mod so we decided to migrate one package at a time.

This migration will allow us to have smaller cassettes thanks to the omitempty tag that was added to the Request and Response structs in v4, so empty fields like transfer_encoding and trailer will not appear in the cassettes.

@Mia-Cross Mia-Cross self-assigned this Oct 27, 2025
@Mia-Cross Mia-Cross added instance Instance issues, bugs and feature requests tests labels Oct 27, 2025
@Mia-Cross Mia-Cross force-pushed the bump_go_vcr_v4_instance branch 2 times, most recently from 92ede0f to 2e0b955 Compare October 28, 2025 13:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 0% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.66%. Comparing base (f89b981) to head (bad5b42).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/acctest/acctest.go 0.00% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3426      +/-   ##
=========================================
- Coverage    1.67%   1.66%   -0.01%     
=========================================
  Files         391     391              
  Lines       43216   43262      +46     
=========================================
  Hits          722     722              
- Misses      42412   42458      +46     
  Partials       82      82              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross marked this pull request as ready for review October 28, 2025 15:54
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners October 28, 2025 15:54
@Mia-Cross Mia-Cross force-pushed the bump_go_vcr_v4_instance branch from c64ddfe to 3cf8ee2 Compare October 28, 2025 15:56
@Mia-Cross Mia-Cross marked this pull request as draft October 28, 2025 17:38
@Mia-Cross Mia-Cross force-pushed the bump_go_vcr_v4_instance branch from 9d64bf3 to bad5b42 Compare October 29, 2025 23:33
@Mia-Cross Mia-Cross marked this pull request as ready for review October 29, 2025 23:38
@remyleone remyleone added this pull request to the merge queue Oct 30, 2025
Merged via the queue into scaleway:master with commit ed9d79b Oct 30, 2025
78 checks passed
@Mia-Cross Mia-Cross deleted the bump_go_vcr_v4_instance branch October 30, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

instance Instance issues, bugs and feature requests tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants