Skip to content

feat(vpcgw): add ipam config #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2023
Merged

feat(vpcgw): add ipam config #2138

merged 2 commits into from
Sep 28, 2023

Conversation

@yfodil
Copy link
Contributor

@yfodil yfodil commented Sep 28, 2023

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Sep 28, 2023
@yfodil yfodil self-assigned this Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023 •
edited
Loading

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (7fb7849) 73.82% compared to head (d83e9be) 73.82%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2138   +/-   ##
=======================================
  Coverage   73.82%   73.82%           
=======================================
  Files         192      192           
  Lines       30358    30399   +41     
=======================================
+ Hits        22411    22442   +31     
- Misses       6036     6046   +10     
  Partials     1911     1911
Files Coverage Δ
scaleway/helpers_vpcgw.go 76.34% <100.00%> (+2.22%) ⬆️
scaleway/resource_vpc_gateway_network.go 63.57% <54.34%> (+0.81%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yfodil yfodil marked this pull request as ready for review September 28, 2023 12:14
@remyleone remyleone added this pull request to the merge queue Sep 28, 2023
Merged via the queue into scaleway:master with commit e1c2568 Sep 28, 2023
Monitob pushed a commit to Codelax/terraform-provider-scaleway that referenced this pull request Oct 3, 2023
@yfodil @Monitob
feat(vpcgw): add ipam config (scaleway#2138)
29868f9 
* feat(vpcgw): add ipam config

* fix
@yfodil yfodil linked an issue Nov 8, 2023 that may be closed by this pull request
Creating private_network with gateway in vpc does not work as expected #2050
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@yfodil yfodil

Labels

enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Creating private_network with gateway in vpc does not work as expected

3 participants

@yfodil @codecov-commenter @remyleone