Skip to content

feat(vpc): remove set subnets private network #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

feat(vpc): remove set subnets private network #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
074a4b2
feat: update generated APIs
scaleway-bot Mar 27, 2025
8ff06c2
Merge branch 'main' into v1.6318.0
Laure-di Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions scaleway-async/scaleway_async/vpc/v2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
from .types import ListVPCsResponse
from .types import SetAclRequest
from .types import SetAclResponse
from .types import SetSubnetsRequest
from .types import SetSubnetsResponse
from .types import UpdatePrivateNetworkRequest
from .types import UpdateRouteRequest
from .types import UpdateVPCRequest
Expand Down Expand Up @@ -78,8 +76,6 @@
"ListVPCsResponse",
"SetAclRequest",
"SetAclResponse",
"SetSubnetsRequest",
"SetSubnetsResponse",
"UpdatePrivateNetworkRequest",
"UpdateRouteRequest",
"UpdateVPCRequest",
Expand Down
50 changes: 0 additions & 50 deletions scaleway-async/scaleway_async/vpc/v2/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
Route,
SetAclRequest,
SetAclResponse,
SetSubnetsRequest,
SetSubnetsResponse,
Subnet,
UpdatePrivateNetworkRequest,
UpdateRouteRequest,
Expand All @@ -52,14 +50,12 @@
unmarshal_ListSubnetsResponse,
unmarshal_ListVPCsResponse,
unmarshal_SetAclResponse,
unmarshal_SetSubnetsResponse,
marshal_AddSubnetsRequest,
marshal_CreatePrivateNetworkRequest,
marshal_CreateRouteRequest,
marshal_CreateVPCRequest,
marshal_DeleteSubnetsRequest,
marshal_SetAclRequest,
marshal_SetSubnetsRequest,
marshal_UpdatePrivateNetworkRequest,
marshal_UpdateRouteRequest,
marshal_UpdateVPCRequest,
Expand Down Expand Up @@ -804,52 +800,6 @@ async def list_subnets_all(
},
)

async def set_subnets(
self,
*,
private_network_id: str,
region: Optional[ScwRegion] = None,
subnets: Optional[List[str]] = None,
) -> SetSubnetsResponse:
"""
Set a Private Network's subnets.
Set subnets for an existing Private Network. Note that the method is PUT and not PATCH. Any existing subnets will be removed in favor of the new specified set of subnets.
:param private_network_id: Private Network ID.
:param region: Region to target. If none is passed will use default region from the config.
:param subnets: Private Network subnets CIDR.
:return: :class:`SetSubnetsResponse <SetSubnetsResponse>`
Usage:
::
result = await api.set_subnets(
private_network_id="example",
)
"""

param_region = validate_path_param(
"region", region or self.client.default_region
)
param_private_network_id = validate_path_param(
"private_network_id", private_network_id
)

res = self._request(
"PUT",
f"/vpc/v2/regions/{param_region}/private-networks/{param_private_network_id}/subnets",
body=marshal_SetSubnetsRequest(
SetSubnetsRequest(
private_network_id=private_network_id,
region=region,
subnets=subnets,
),
self.client,
),
)

self._throw_on_error(res)
return unmarshal_SetSubnetsResponse(res.json())

async def add_subnets(
self,
*,
Expand Down
29 changes: 0 additions & 29 deletions scaleway-async/scaleway_async/vpc/v2/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@
ListSubnetsResponse,
ListVPCsResponse,
SetAclResponse,
SetSubnetsResponse,
AddSubnetsRequest,
CreatePrivateNetworkRequest,
CreateRouteRequest,
CreateVPCRequest,
DeleteSubnetsRequest,
SetAclRequest,
SetSubnetsRequest,
UpdatePrivateNetworkRequest,
UpdateRouteRequest,
UpdateVPCRequest,
Expand Down Expand Up @@ -440,21 +438,6 @@ def unmarshal_SetAclResponse(data: Any) -> SetAclResponse:
return SetAclResponse(**args)


def unmarshal_SetSubnetsResponse(data: Any) -> SetSubnetsResponse:
if not isinstance(data, dict):
raise TypeError(
"Unmarshalling the type 'SetSubnetsResponse' failed as data isn't a dictionary."
)

args: Dict[str, Any] = {}

field = data.get("subnets", None)
if field is not None:
args["subnets"] = field

return SetSubnetsResponse(**args)


def marshal_AddSubnetsRequest(
request: AddSubnetsRequest,
defaults: ProfileDefaults,
Expand Down Expand Up @@ -605,18 +588,6 @@ def marshal_SetAclRequest(
return output


def marshal_SetSubnetsRequest(
request: SetSubnetsRequest,
defaults: ProfileDefaults,
) -> Dict[str, Any]:
output: Dict[str, Any] = {}

if request.subnets is not None:
output["subnets"] = request.subnets

return output


def marshal_UpdatePrivateNetworkRequest(
request: UpdatePrivateNetworkRequest,
defaults: ProfileDefaults,
Expand Down
23 changes: 0 additions & 23 deletions scaleway-async/scaleway_async/vpc/v2/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,29 +806,6 @@ class SetAclResponse:
default_policy: Action


@dataclass
class SetSubnetsRequest:
private_network_id: str
"""
Private Network ID.
"""

region: Optional[ScwRegion]
"""
Region to target. If none is passed will use default region from the config.
"""

subnets: Optional[List[str]]
"""
Private Network subnets CIDR.
"""


@dataclass
class SetSubnetsResponse:
subnets: List[str]


@dataclass
class UpdatePrivateNetworkRequest:
private_network_id: str
Expand Down
4 changes: 0 additions & 4 deletions scaleway/scaleway/vpc/v2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@
from .types import ListVPCsResponse
from .types import SetAclRequest
from .types import SetAclResponse
from .types import SetSubnetsRequest
from .types import SetSubnetsResponse
from .types import UpdatePrivateNetworkRequest
from .types import UpdateRouteRequest
from .types import UpdateVPCRequest
Expand Down Expand Up @@ -78,8 +76,6 @@
"ListVPCsResponse",
"SetAclRequest",
"SetAclResponse",
"SetSubnetsRequest",
"SetSubnetsResponse",
"UpdatePrivateNetworkRequest",
"UpdateRouteRequest",
"UpdateVPCRequest",
Expand Down
50 changes: 0 additions & 50 deletions scaleway/scaleway/vpc/v2/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
Route,
SetAclRequest,
SetAclResponse,
SetSubnetsRequest,
SetSubnetsResponse,
Subnet,
UpdatePrivateNetworkRequest,
UpdateRouteRequest,
Expand All @@ -52,14 +50,12 @@
unmarshal_ListSubnetsResponse,
unmarshal_ListVPCsResponse,
unmarshal_SetAclResponse,
unmarshal_SetSubnetsResponse,
marshal_AddSubnetsRequest,
marshal_CreatePrivateNetworkRequest,
marshal_CreateRouteRequest,
marshal_CreateVPCRequest,
marshal_DeleteSubnetsRequest,
marshal_SetAclRequest,
marshal_SetSubnetsRequest,
marshal_UpdatePrivateNetworkRequest,
marshal_UpdateRouteRequest,
marshal_UpdateVPCRequest,
Expand Down Expand Up @@ -804,52 +800,6 @@ def list_subnets_all(
},
)

def set_subnets(
self,
*,
private_network_id: str,
region: Optional[ScwRegion] = None,
subnets: Optional[List[str]] = None,
) -> SetSubnetsResponse:
"""
Set a Private Network's subnets.
Set subnets for an existing Private Network. Note that the method is PUT and not PATCH. Any existing subnets will be removed in favor of the new specified set of subnets.
:param private_network_id: Private Network ID.
:param region: Region to target. If none is passed will use default region from the config.
:param subnets: Private Network subnets CIDR.
:return: :class:`SetSubnetsResponse <SetSubnetsResponse>`
Usage:
::
result = api.set_subnets(
private_network_id="example",
)
"""

param_region = validate_path_param(
"region", region or self.client.default_region
)
param_private_network_id = validate_path_param(
"private_network_id", private_network_id
)

res = self._request(
"PUT",
f"/vpc/v2/regions/{param_region}/private-networks/{param_private_network_id}/subnets",
body=marshal_SetSubnetsRequest(
SetSubnetsRequest(
private_network_id=private_network_id,
region=region,
subnets=subnets,
),
self.client,
),
)

self._throw_on_error(res)
return unmarshal_SetSubnetsResponse(res.json())

def add_subnets(
self,
*,
Expand Down
29 changes: 0 additions & 29 deletions scaleway/scaleway/vpc/v2/marshalling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@
ListSubnetsResponse,
ListVPCsResponse,
SetAclResponse,
SetSubnetsResponse,
AddSubnetsRequest,
CreatePrivateNetworkRequest,
CreateRouteRequest,
CreateVPCRequest,
DeleteSubnetsRequest,
SetAclRequest,
SetSubnetsRequest,
UpdatePrivateNetworkRequest,
UpdateRouteRequest,
UpdateVPCRequest,
Expand Down Expand Up @@ -440,21 +438,6 @@ def unmarshal_SetAclResponse(data: Any) -> SetAclResponse:
return SetAclResponse(**args)


def unmarshal_SetSubnetsResponse(data: Any) -> SetSubnetsResponse:
if not isinstance(data, dict):
raise TypeError(
"Unmarshalling the type 'SetSubnetsResponse' failed as data isn't a dictionary."
)

args: Dict[str, Any] = {}

field = data.get("subnets", None)
if field is not None:
args["subnets"] = field

return SetSubnetsResponse(**args)


def marshal_AddSubnetsRequest(
request: AddSubnetsRequest,
defaults: ProfileDefaults,
Expand Down Expand Up @@ -605,18 +588,6 @@ def marshal_SetAclRequest(
return output


def marshal_SetSubnetsRequest(
request: SetSubnetsRequest,
defaults: ProfileDefaults,
) -> Dict[str, Any]:
output: Dict[str, Any] = {}

if request.subnets is not None:
output["subnets"] = request.subnets

return output


def marshal_UpdatePrivateNetworkRequest(
request: UpdatePrivateNetworkRequest,
defaults: ProfileDefaults,
Expand Down
23 changes: 0 additions & 23 deletions scaleway/scaleway/vpc/v2/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,29 +806,6 @@ class SetAclResponse:
default_policy: Action


@dataclass
class SetSubnetsRequest:
private_network_id: str
"""
Private Network ID.
"""

region: Optional[ScwRegion]
"""
Region to target. If none is passed will use default region from the config.
"""

subnets: Optional[List[str]]
"""
Private Network subnets CIDR.
"""


@dataclass
class SetSubnetsResponse:
subnets: List[str]


@dataclass
class UpdatePrivateNetworkRequest:
private_network_id: str
Expand Down