Support Scala Native 0.4.3+ #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing, I had a quick look at the test failures and they seem unrelated (the debug test started failing randomly on ubuntu recently, no idea why). The windows one about JS looks new though, could it have soemthing to do with the chanegs? |
|
@tgodzik I have no idea if it can be related, maybe you can re-run the workflows to see if it fails again? It seems that only the graalvm-ce one is failing on windows tho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala Native 0.4.3 changed how main methods are resolved: https://scala-native.readthedocs.io/en/latest/changelog/0.4.3.html#changes-to-the-main-method-resolving
The failures in CI seem unrelated...