Skip to content

Move Pure to caps and make it non-experimental #23745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

natsukagami
Copy link
Contributor

@natsukagami natsukagami commented Aug 14, 2025

This PR consists of two commits:

  • The first one moves scala.Pure to scala.caps.Pure, updating all relevant references and tests
  • The second one drops @experimental, marking it stable in accordance with the status of scala.caps's other non-experimental symbols.

Pure has always been a capture-checking only class.

@natsukagami natsukagami marked this pull request as ready for review August 15, 2025 11:59
@natsukagami natsukagami requested a review from a team as a code owner August 15, 2025 11:59
@natsukagami natsukagami requested a review from bracevac August 15, 2025 11:59
@@ -191,7 +191,7 @@ class Erasure extends Phase with DenotTransformer {
|| isAllowed(defn.TupleClass, "Tuple.scala")
|| isAllowed(defn.NonEmptyTupleClass, "Tuple.scala")
|| isAllowed(defn.PairClass, "Tuple.scala")
|| isAllowed(defn.PureClass, "Pure.scala"),
|| isAllowed(defn.PureClass, /* caps/ */ "Pure.scala"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment truly necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a reminder, since isAllowed only checks the file name and not the full path

@natsukagami natsukagami enabled auto-merge (rebase) August 15, 2025 12:20
@natsukagami natsukagami disabled auto-merge August 15, 2025 12:20
@natsukagami natsukagami enabled auto-merge August 15, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants