Backport "Quotes reflect: Allow to return DefDef from a val symbol tree" to 3.3 LTS #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…22603) During the `Getters` phase, the compiler replaces class member vals with defs. Meanwhile `.tree` returns a tree most recently associated with a symbol (if currently compiled), or one read from tasty (if compiled before). An interesting thing happens in the issue - since all of the files are tried being compiled in one compilation run, the file with a macro call is suspended, and then the macro and the MyClass class definition are compiled to the end (also including the `Getters` phase, where the tree stops being a ValDef). Initially I thought about manually replacing that returned DefDef with a ValDef in quotes reflection (like what happens when the tree is not available), but that would have been pointless - there would be little use of calling `.tree` on a symbol if we cannot read the rhs of the definition. Returning raw DefDef seems like a less bad choice, especially `.tree` is meant to be for power users anyway, and is full of other, more dangerous warts. [Cherry-picked 4788641]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports scala#22603 to the 3.3.7.
PR submitted by the release tooling.
[skip ci]