Re-enable Windows BSP domain socket tests #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
reenable-windows-local-bsp-tests
branch
3 times, most recently
from
37dd29a to
ac07612
Compare
alexarchambault
force-pushed
the
reenable-windows-local-bsp-tests
branch
from
ac07612 to
ec1795d
Compare
alexarchambault
force-pushed
the
reenable-windows-local-bsp-tests
branch
from
ec1795d to
260f85a
Compare
alexarchambault
force-pushed
the
reenable-windows-local-bsp-tests
branch
from
260f85a to
4086ed3
Compare
Closing client sockets might not interrupt on-going reads or writes on Windows, which this test can't accomodate. Don't know if this can have consequences for Bloop users…
alexarchambault
force-pushed
the
reenable-windows-local-bsp-tests
branch
from
4086ed3 to
336f57d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.