Skip to content

Add test for implicit configuration coming from imported, forward module #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2025
Merged

Add test for implicit configuration coming from imported, forward module #2083

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2946b54
Add test for implicit configuration coming from imported, forward module
jathak Sep 5, 2025
519d684
Code review
jathak Sep 5, 2025
6bcd990
Fix line numbers
jathak Sep 5, 2025
16b8eed
Actually fix line numbers
jathak Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 51 additions & 6 deletions spec/directives/import/configuration.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,26 +87,26 @@ More info and automated migrator: https://sass-lang.com/d/import

<===>
================================================================================
<===> separate_file/input.scss
<===> separate_file/direct/input.scss
@import "config";
@import "midstream";

<===> separate_file/_config.scss
<===> separate_file/direct/_config.scss
$a: configured;

<===> separate_file/_midstream.scss
<===> separate_file/direct/_midstream.scss
@forward "upstream";

<===> separate_file/_upstream.scss
<===> separate_file/direct/_upstream.scss
$a: original !default;
b {c: $a}

<===> separate_file/output.css
<===> separate_file/direct/output.css
b {
c: configured;
}

<===> separate_file/warning
<===> separate_file/direct/warning
DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import
Expand All @@ -119,6 +119,51 @@ More info and automated migrator: https://sass-lang.com/d/import

DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

,
2 | @import "midstream";
| ^^^^^^^^^^^
'
input.scss 2:9 root stylesheet

<===>
================================================================================
<===> separate_file/through_forward/input.scss
@import "config_wrapper";
Copy link
Contributor

@nex3 nex3 Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a silent comment here indicating the issue for which this is a regression test?

@import "midstream";

<===> separate_file/through_forward/_config_wrapper.scss
@forward "config";

<===> separate_file/through_forward/_config.scss
$a: configured;

<===> separate_file/through_forward/_midstream.scss
@forward "upstream";

<===> separate_file/through_forward/_upstream.scss
$a: original !default;
b {c: $a}

<===> separate_file/through_forward/output.css
b {
c: configured;
}

<===> separate_file/through_forward/warning
DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

,
1 | @import "config_wrapper";
| ^^^^^^^^^^^^^^^^
'
input.scss 1:9 root stylesheet

DEPRECATION WARNING [import]: Sass @import rules are deprecated and will be removed in Dart Sass 3.0.0.

More info and automated migrator: https://sass-lang.com/d/import

,
Expand Down
Loading