Skip to content

Conversation

@dmdunla
Copy link
Collaborator

@dmdunla dmdunla commented Jan 31, 2025


📚 Documentation preview 📚: https://pyttb--385.org.readthedocs.build/en/385/

@dmdunla dmdunla self-assigned this Jan 31, 2025
@dmdunla dmdunla requested a review from ntjohnson1 January 31, 2025 17:02
Copy link
Collaborator

@ntjohnson1 ntjohnson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for this use case. It might make sense for use to globally replace the @ operator with this more explicit version throughout the project if we hit this issue in the future.

@dmdunla
Copy link
Collaborator Author

dmdunla commented Feb 2, 2025

OK, will merge this now and add Issue to make this consistent across the board later.

@dmdunla dmdunla merged commit 93aabbd into main Feb 2, 2025
10 checks passed
@dmdunla dmdunla deleted the 384-internal-method-tensorttt-outputs-warning-when-computing-partial-contractions branch February 2, 2025 15:10
@ntjohnson1
Copy link
Collaborator

Makes sense. I pushed through the bulk of the memory layout stuff in one go and figured there would be some fixes in the tail end required. The loud warnings should help point them out, but won't break functionality. Mostly just highlighting slight inefficiencies.

As we fix the remaining pieces we should get pretty close to supporting C or F order and it'll just be a matter of prioritizing that and making sure our test coverage is appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Internal method tensor.ttt outputs WARNING when computing partial contractions

3 participants