-
Notifications
You must be signed in to change notification settings - Fork 16
Dev deps #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Dev deps #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adly than before.
* Locally verified 1.24, wouldn't be too hard to update to support older if desired
Merged
dmdunla
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to go except suggestion for a change in the info for contributors when running tests. The issue may have been introduced before, but I just noticed it with this PR.
dmdunla
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some discussion after the pause in development.
There's definitely some future work that could be done on the versions if we wanted to be more diligent. I mostly just got it working. We used to support back to numpy 1.19 but we added a handful of features from 1.24. If there's a desire to support older deps we should be able to use the current setup to make the version width more flexible.
📚 Documentation preview 📚: https://pyttb--330.org.readthedocs.build/en/330/