Skip to content

Conversation

@ntjohnson1
Copy link
Collaborator

@ntjohnson1 ntjohnson1 commented Nov 3, 2024

Based on some discussion after the pause in development.

  1. Updates our pinned ruff
  2. Replaces black with ruff format (faster and one less dependency)
  3. Runs ruff format which formatted the code in our doc strings
  4. Sets some versioning around our packages and uses UV as a pretty simple way to test the oldest version specified by our package.

There's definitely some future work that could be done on the versions if we wanted to be more diligent. I mostly just got it working. We used to support back to numpy 1.19 but we added a handful of features from 1.24. If there's a desire to support older deps we should be able to use the current setup to make the version width more flexible.


📚 Documentation preview 📚: https://pyttb--330.org.readthedocs.build/en/330/

@ntjohnson1 ntjohnson1 marked this pull request as ready for review November 10, 2024 14:15
@ntjohnson1 ntjohnson1 requested a review from dmdunla November 10, 2024 14:15
@ntjohnson1 ntjohnson1 mentioned this pull request Nov 10, 2024
Copy link
Collaborator

@dmdunla dmdunla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to go except suggestion for a change in the info for contributors when running tests. The issue may have been introduced before, but I just noticed it with this PR.

@dmdunla dmdunla merged commit 6a71510 into sandialabs:main Nov 11, 2024
9 checks passed
@ntjohnson1 ntjohnson1 deleted the dev_deps branch November 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants