Default behavior of divmod() is different from MATLAB mod(), on which… #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the original logic was based. The prior logic threw a ZeroDivisionError if printitn == 0. Instead, this fix avoids this error by testing that printitn > 0. Tests added for various values of printitn.
ntjohnson1
reviewed
Sep 15, 2023
Collaborator
ntjohnson1
left a comment
ntjohnson1
left a comment
There was a problem hiding this comment.
A few small desired cleanups then looks good to me and @dmdunla can merge. Thanks!
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
…CPU cycles. Also removing output since nothing is actually checked.
ntjohnson1
approved these changes
Sep 16, 2023
dmdunla
merged commit efaf16c
into
sandialabs:235-cp_als-with-option-printitn=0-causes-zerodivisionerror
dmdunla
added a commit
that referenced
this pull request
Sep 16, 2023
#242) * Default behavior of divmod() is different from MATLAB mod(), on which… (#237) * Default behavior of divmod() is different from MATLAB mod(), on which the original logic was based. The prior logic threw a ZeroDivisionError if printitn == 0. Instead, this fix avoids this error by testing that printitn > 0. Tests added for various values of printitn. * Update tests/test_cp_als.py Co-authored-by: Nick <[email protected]> * Update tests/test_cp_als.py Co-authored-by: Nick <[email protected]> * Applying Nick's suggesetions to remove mark, change maxiters to save CPU cycles. Also removing output since nothing is actually checked. * Removes mark * Closes #235 --------- Co-authored-by: Jeremy Myers <[email protected]> Co-authored-by: Nick <[email protected]> * black: fixing black formatting --------- Co-authored-by: Jeremy Myers <[email protected]> Co-authored-by: Jeremy Myers <[email protected]> Co-authored-by: Nick <[email protected]>
jeremy-myers
deleted the
235-cp_als-with-option-printitn=0-causes-zerodivisionerror
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the original logic was based. The prior logic threw a ZeroDivisionError if printitn == 0. Instead, this fix avoids this error by testing that printitn > 0. Tests added for various values of printitn.
📚 Documentation preview 📚: https://pyttb--237.org.readthedocs.build/en/237/