Nick/tensor scale #221
Merged
Nick/tensor scale #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update interface for mypy to check * Update simple tests to confirm
* Add scale and tests * Didn't add exclude dims, but could to match MATLAB * Skipped the function handle since that seems redudant with other functionality we have
* Forgot negative test
* Typo in my TODO
dmdunla
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #76 since I believe things should just work out of the box with interface similarities. Let me know if you saw a bug or ran into some issue I didn't capture.
Added a limited coverage of scale consistent with our sptensor interface which should resolve #26. I don't know the full usage so unclear if having exclude dims as well is a must have. Left a few todos where we could probably improve our tt_dimscheck and one weird reshaping issue that I didn't root cause if it was a column vs row thing or C vs Fortran layout thing.
📚 Documentation preview 📚: https://pyttb--221.org.readthedocs.build/en/221/