Allow the quality to be a string #878
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To me this seems like a complicated way to end up not knowing what the type is anyway. Would rather have it switching the type consistently to string, or not enforcing a type. Then instead adapting PS: I'm not the maintainer, so you may want to wait for Sam's opinions |
|
@jacoz126 Learn how to solve your own problems instead of being our problem. |
|
I close this in favour of a different approach I'm working on. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sumary of proposed changes
In my case I needed the qualities to be represented as string, because one of them is
audiodescription.I removed the
Number()calls and replaced them with a new function calledmapQualityUnit. It converts numbers to numbers, and keeps strings to be strings.Task list