Skip to content

fix: blankVideo type #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2020
Merged

fix: blankVideo type #1928

merged 1 commit into from
Aug 30, 2020

Conversation

@ethanve
Copy link
Contributor

@ethanve ethanve commented Aug 12, 2020 •
edited
Loading

Link to related issue (if applicable)

Fix the blankVideo type

Summary of proposed changes

Checklist

  • Use develop as the base branch
  • Exclude the gulp build (/dist changes) from the PR
  • Test on supported browsers

@ethanve ethanve changed the base branch from develop to master August 12, 2020 14:12
@ethanve ethanve changed the title Patch 1 fix: blankVideo type Aug 12, 2020
sampotts
sampotts approved these changes Aug 30, 2020
View reviewed changes
Copy link
Owner

@sampotts sampotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@sampotts sampotts merged commit 8261ebd into sampotts:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampotts sampotts sampotts approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanve @sampotts