Enable Solidity IR Optimizations #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
approved these changes
Feb 26, 2024
Contributor
|
Source: https://github.com/sc-forks/solidity-coverage/releases/tag/v0.8.7 |
nlordell
force-pushed
the
chore/enable-ir-optimizations
branch
from
b145d61 to
a1bcb49
Compare
Collaborator
Author
|
Oh man, this led down a rabbit hole... but should be fixed now :) |
nlordell
commented
Feb 26, 2024
| expect(safeTokenLock.connect(alice).rescueToken(ZeroAddress, ZeroAddress, 0)) | ||
| .to.be.revertedWithCustomError(safeTokenLock, 'OwnableUnauthorizedAccount') | ||
| .withArgs(alice) | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
Note that I changed the order of the tests... While this may seem silly, there is a reason. The solidity-coverage took has some extra "hash de-duplication" logic when compiling via IR which messes up branch coverage computation. Changing the order of the tests fixes this. See:
sc-forks/solidity-coverage#863
sc-forks/solidity-coverage#868
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns on the IR optimization flag when invoking the Solidity compiler for the Safe token lock contracts. There are small gas savings across the board (exception with small gas overhead when withdrawing 0 amounts, which we do not need to optimize for) and moderate code size savings:
Before
After