Skip to content

Conversation

@IaroslavMazur
Copy link
Member

@IaroslavMazur IaroslavMazur commented Apr 29, 2025

Depends on #86.

chore: remove the bytemuck dependency hotfix
chore: update other dependencies

Note: We shouldn't reference a specific Rust toolchain version from the past, as it'll, normally, become incompatible with the rest of the dependencies quite soon - and require regular maintenance.

Referencing the generic toolchain kind (i.e. nightly or stable) is the way.

@IaroslavMazur IaroslavMazur changed the base branch from iaro/rust-toolchain-version to main April 29, 2025 15:23
Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't reference a specific Rust toolchain version from the past, as it'll, normally, become incompatible with the rest of the dependencies quite soon - and require regular maintenance.

that's correct only if we update the other dependencies as well, right?
the idea is to have a stable version of deps — so that we won't update them constantly, causing continuous refactors

my motivation for having a fixed version for building the program is to make it pass no matter what someone uses locally — it may be 2025-04-01 or not — but we should aim, IMO, for a stable version

@IaroslavMazur
Copy link
Member Author

IaroslavMazur commented Apr 30, 2025

that's correct only if we update the other dependencies as well, right? the idea is to have a stable version of deps — so that we won't update them constantly, causing continuous refactors
my motivation for having a fixed version for building the program is to make it pass no matter what someone uses locally — it may be 2025-04-01 or not — but we should aim, IMO, for a stable version

Generally speaking, we should either "pin" all of the tool versions (for Rust, Anchor & Solana) - or none, at all, because, sometimes, they develop independently, leading to incompatibilities between them (this is what happened recently, e.g.).

Now, I'm not sure it'd be a good idea to enforce any specific tool version in either the bun scripts or the GitHub workflows, because together with "making the build pass" (when this can "fix" any local config issues), this would, also, hide/obfuscate any tool version compatibility issues in case (partially) pinning them is not enough. The latter would make fixing the root cause of the issue harder.

The argument for not enforcing the tool versions in bun scripts is identifying any compatibility issues sooner (i.e. not hiding them if there are any in the local env config of the developer), and in GH workflows - because that's the last level of validations that's happening before the code is being integrated into main - and, then, deployed on-chain.

Open for further discussion.

This was referenced Apr 30, 2025
IaroslavMazur and others added 2 commits May 2, 2025 14:53
chore: update Anchor version

chore: remove the bytemuck dependency hotfix
chore: update other dependencies

test: increase CU limit for failing tests (#88)

refactor: change verification order at Stream Creation
(motivation: previously, passing an endTime < startTime resulted in
the CliffTimeNotLessThanEndTime error being returned)

chore: update bun dependencies
* feat: RefundableAmountOf Ix

* depleted status

* refactor: move common view context file to its file

* refactor: rename the common context

* refactor: rename view context

---------

Co-authored-by: Andrei Vlad Birgaoanu <[email protected]>
@andreivladbrg andreivladbrg merged commit d87d62a into main May 2, 2025
1 check passed
@andreivladbrg andreivladbrg deleted the iaro/dependencies branch May 2, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants