This repository was archived by the owner on Oct 30, 2019. It is now read-only.
Use doc(no_inline) on unnamed prelude exports #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Oct 10, 2019
Collaborator
yoshuawuyts
left a comment
yoshuawuyts
left a comment
There was a problem hiding this comment.
LGTM -- though I'd like to take a moment to note we may want to start winding down work on Runtime and eventually retire the project entirely in favor of recommending people use async-std or tokio.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #115
Refs: rust-lang/futures-rs#1662 (comment)
Screenshot:
Before (master):
After (this PR):
Motivation and Context
Types of changes