Add efi_rng opt-in backend
#570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
reviewed
Dec 18, 2024
| impl Error { | ||
| pub(crate) const BOOT_SERVICES_UNAVAILABLE: Error = Self::new_internal(10); | ||
| pub(crate) const NO_RNG_HANDLE: Error = Self::new_internal(11); | ||
| pub(crate) const TEMP_EFI_ERROR: Error = Self::new_internal(12); |
There was a problem hiding this comment.
Do we need TEMP_EFI_ERROR now if we have #569 ?
There was a problem hiding this comment.
As I wrote in the OP, to encapsulate the UEFI status codes we need a wider state than 32-bits. Technically, on x86-64 we need 64 bits, but we probably can use NonZeroU64 since status codes with prefixes 0x1, 0x3, and 0x7 are used for "warning" codes.
josephlr
reviewed
Dec 23, 2024
There was a problem hiding this comment.
Two questions:
- Do we think that adding in this backend is a blocker for 0.3?
- Is there a reason to have this be opt-in rather than our default implementation for the UEFI target? (Especially now that an alternative backend like
rdrandcan be enabled even on supported targets).
No, it's not a blocker and may be left for a later release.
There are two reasons:
|
Merged
newpavlov
added a commit
that referenced
this pull request
Mar 17, 2025
### Added - `efi_rng` opt-in backend [#570] - `linux_raw` opt-in backend [#572] - `.cargo/config.toml` example in the crate-level docs [#591] - `getrandom_test_linux_without_fallback` configuration flag to test that file fallback is not triggered in the `linux_android_with_fallback` backend [#605] - Built-in support for `*-linux-none` targets [#618] - Cygwin support [#626] ### Changed - Update `wasi` dependency to v0.14 [#594] - Add `#[inline]` attribute to the inner functions [#596] - Update WASI and Emscripten links in the crate-level docs [#597] - Do not use `dlsym` on MUSL targets in the `linux_android_with_fallback` backend [#602] - Remove `linux_android.rs` and use `getrandom.rs` instead [#603] - Always use `RtlGenRandom` on Windows targets when compiling with pre-1.78 Rust [#610] - Internal representation of the `Error` type [#614] - Remove `windows-targets` dependency and use [`raw-dylib`] directly [#627] ### Removed - `Error::INTERNAL_START` and `Error::CUSTOM_START` associated constants [#614] [#570]: #570 [#572]: #572 [#591]: #591 [#594]: #594 [#596]: #596 [#597]: #597 [#602]: #602 [#603]: #603 [#605]: #605 [#610]: #610 [#614]: #614 [#618]: #618 [#626]: #626 [#627]: #627 [`raw-dylib`]: https://doc.rust-lang.org/reference/items/external-blocks.html?highlight=link#dylib-versus-raw-dylib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation is based on the
stdcode. I am not sure why we need the try loop over protocol handles instead of just getting the first handle, but I decided to just followstdhere.Because the backend requires access to
BootServicesit has to rely on the unstableuefi_stdfeature. We could alternatively use theueficrate, but it would tie the backend to theueficrate environment, which is probably not desirable.TEMP_EFI_ERRORis used as a temporary solution until #568 is resolved, which I plan to do in a separate PR.cc @usamoi @nicholasbishop