Skip to content

Use shared File instead of shared FD. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2019
Merged

Use shared File instead of shared FD. #45

merged 1 commit into from
Jun 29, 2019

Conversation

@josephlr
Copy link
Member

@josephlr josephlr commented Jun 28, 2019

Fixes #44 and removes use of unsafe code.

This can be implemented without unsafe because &'_ File implements Read, indicating that files can be read by multiple readers at the same time.

@josephlr
Copy link
Member Author

josephlr commented Jun 28, 2019

Tested on Linux with and without getrandom syscall enabled.

@newpavlov
Copy link
Member

newpavlov commented Jun 29, 2019

TIL about &File implementing Read. :)

@newpavlov newpavlov merged commit 11eefaa into rust-random:master Jun 29, 2019
@josephlr josephlr deleted the fd branch June 29, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@newpavlov newpavlov newpavlov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shared file descriptor is closed prematurely

2 participants

@josephlr @newpavlov