remove eprintln #110
Open
remove eprintln #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnorpelSenf
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
I'm pretty sure it was just forgotten, but let's wait for @lovasoa to confirm
|
I guess we first need to fix CI, but that is unrelated to these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In how I'm using this crate not getting a solution to the constraints is a common thing and this eprintln is showing up in console output in context where no one would know where it came from. Seems like this can just be removed? Not sure if you want to add tracing or log crate dependency just for this.