Skip to content

Make argmin/max_skipnan use EmptyInput error type #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2019
Merged

Make argmin/max_skipnan use EmptyInput error type #37

merged 1 commit into from
Apr 12, 2019

Conversation

jturner314
Copy link
Member

Neither method uses the UndefinedOrder variant, so there's no reason to use the MinMaxError enum instead of just the EmptyInput struct.

@jturner314
Make argmin/max_skipnan use EmptyInput error type
32bd365 
Neither method uses the `UndefinedOrder` variant, so there's no reason
to use the `MinMaxError` enum instead of just the `EmptyInput` struct.
@jturner314 jturner314 added Breaking changes Enhancement New feature or request labels Apr 11, 2019
LukeMathWalker
LukeMathWalker approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@LukeMathWalker LukeMathWalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

@LukeMathWalker LukeMathWalker merged commit 5abbc48 into master Apr 12, 2019
@LukeMathWalker LukeMathWalker deleted the argmin-skipnan-error branch April 12, 2019 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeMathWalker LukeMathWalker LukeMathWalker approved these changes

Assignees
No one assigned
Labels
Breaking changes Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jturner314 @LukeMathWalker