Skip to content

Conversation

Nugine
Copy link
Contributor

@Nugine Nugine commented Nov 26, 2022

Resolves #827

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Nov 27, 2022

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Nov 27, 2022

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@dtolnay
Copy link
Member

dtolnay commented Dec 20, 2022

I'm marking @yaahc's box because she has stepped down from T-libs-api after the point that this feature got proposed for FCP.

@rfcbot
Copy link

rfcbot commented Dec 20, 2022

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @Amanieu, I wasn't able to add the final-comment-period label, please do so.

@dtolnay dtolnay added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Dec 20, 2022
@rfcbot
Copy link

rfcbot commented Dec 30, 2022

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

psst @Amanieu, I wasn't able to add the finished-final-comment-period label, please do so.

@Amanieu
Copy link
Member

Amanieu commented Jan 5, 2023

Note that cmpxchg16b_target_feature is still unstable in rustc, a separate PR is needed there to stabilize it.

@Amanieu Amanieu merged commit f151316 into rust-lang:master Jan 5, 2023
@Nugine Nugine deleted the cmpxchg16b branch January 6, 2023 07:53
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 28, 2023
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ rust-lang#44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
saethlin pushed a commit to saethlin/miri that referenced this pull request Mar 5, 2023
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ #44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request May 31, 2023
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ #44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 20, 2024
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ #44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
Stabilize cmpxchg16b_target_feature

Tracking issue for target features
+ #44839

stdarch issue
+ rust-lang/stdarch#827

stdarch PR
+ rust-lang/stdarch#1358

reference PR
+ rust-lang/reference#1331

It's my first time contributing to rust-lang/rust. Please tell me if I missed something.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize cmpxchg16b
5 participants