Skip to content

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Nov 10, 2020

This cuts down compile times by 10 seconds out of a 35 second build.

Before: https://jyn514.github.io/assets/cargo-timing-reqwest.html
After: https://jyn514.github.io/assets/cargo-timing-attohttpc.html

@jyn514
Copy link
Member Author

jyn514 commented Nov 10, 2020

This also gets rid of several duplicate dependencies:

pin-project v0.4.27
└── tracing-futures v0.2.4 (*)

pin-project v1.0.1
├── futures-util v0.3.8
│   ├── h2 v0.2.7 (*)
│   ├── hyper v0.13.9 (*)
│   ├── reqwest v0.10.8 (*)
│   └── rustwide v0.11.0 (/home/joshua/rustwide)
└── hyper v0.13.9 (*)

pin-project-internal v0.4.27 (proc-macro)
└── pin-project v0.4.27 (*)

pin-project-internal v1.0.1 (proc-macro)
└── pin-project v1.0.1 (*)

@pietroalbini
Copy link
Member

Hmm, Linux builds are hanging due to this.

@jyn514
Copy link
Member Author

jyn514 commented Nov 12, 2020

Strangely, this hangs when calling docker, not when making HTTP requests:

[INFO  rustwide::cmd::sandbox] pulling image rustops/crates-build-env from Docker Hub
[INFO  rustwide::cmd] running `Command { std: "docker" "pull" "rustops/crates-build-env", kill_on_drop: false }`
test run_binary_with_same_name_as_file ... test run_binary_with_same_name_as_file has been running for over 60 seconds

On master, it works fine:

[INFO  rustwide::cmd::sandbox] pulling image rustops/crates-build-env from Docker Hub
[INFO  rustwide::cmd] running `Command { std: "docker" "pull" "rustops/crates-build-env", kill_on_drop: false }`
[INFO  rustwide::cmd] [stdout] Using default tag: latest
[INFO  rustwide::cmd] [stdout] latest: Pulling from rustops/crates-build-env
[INFO  rustwide::cmd] [stdout] 6a5697faee43: Pulling fs layer

Not sure why my changed would have affected running docker.

@jyn514
Copy link
Member Author

jyn514 commented Nov 12, 2020

... if this is because a tokio feature is no longer pulled in by reqwest, I'm going to be really mad.

@pietroalbini pietroalbini merged commit 7a4ef73 into rust-lang:master Nov 12, 2020
@jyn514 jyn514 deleted the attohttpc branch November 12, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants