Skip to content

Conversation

@rami3l
Copy link
Member

@rami3l rami3l commented Oct 21, 2025

Addresses #4513 (comment).

@rami3l rami3l requested a review from djc October 21, 2025 14:57
@rami3l rami3l force-pushed the cli/discuss-install-tips branch from 643c4e1 to d7280c8 Compare October 21, 2025 14:58
@rami3l rami3l force-pushed the cli/discuss-install-tips branch from d7280c8 to a9fb1ca Compare October 21, 2025 15:17
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Should we also show this for update?

Tiny nit: I would use lowercase after ":".

@rami3l rami3l force-pushed the cli/discuss-install-tips branch from a9fb1ca to 23992a5 Compare October 22, 2025 02:07
@rami3l
Copy link
Member Author

rami3l commented Oct 22, 2025

@djc Thanks for the review! I've addressed the concerns accordingly along with a tiny fix that turns out to be a leftover from #3596.

@rami3l
Copy link
Member Author

rami3l commented Oct 22, 2025

@epage Remaining concern from #4551: do you think it's a good idea to indent all discussions by 2 spaces instead of 4, or are you sure that clap segments are indented by 2 spaces? The current style (see the svg diffs in this PR) is a bit confusing...

@epage
Copy link
Contributor

epage commented Oct 22, 2025

Note that that we reduced the padding between clap v3 and v4, see https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#400---2022-09-28

@rami3l
Copy link
Member Author

rami3l commented Oct 22, 2025

Note that that we reduced the padding between clap v3 and v4, see https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#400---2022-09-28

@epage Ah I see why the current indentation is what it is. Maybe that deserves another PR to fix? For this patch in particular let's just stay with the old style then.

@rami3l rami3l added this pull request to the merge queue Oct 22, 2025
Merged via the queue into rust-lang:main with commit ca0c14a Oct 22, 2025
29 checks passed
@rami3l rami3l deleted the cli/discuss-install-tips branch October 22, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants