-
Notifications
You must be signed in to change notification settings - Fork 984
feat(cli/help): discuss rustup toolchain install
#4554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
643c4e1 to
d7280c8
Compare
d7280c8 to
a9fb1ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Should we also show this for update?
Tiny nit: I would use lowercase after ":".
a9fb1ca to
23992a5
Compare
|
Clap indents sections by 2 spaces but for flags, that two spaces is for where the short flags is placed. |
|
Note that that we reduced the padding between clap v3 and v4, see https://github.com/clap-rs/clap/blob/master/CHANGELOG.md#400---2022-09-28 |
@epage Ah I see why the current indentation is what it is. Maybe that deserves another PR to fix? For this patch in particular let's just stay with the old style then. |
Addresses #4513 (comment).