More unit testifications #2416
Merged
More unit testifications #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One integration test kept as a smoke test for insurance.
rbtcollins
changed the title
rbtcollins
force-pushed
the
unit-tests
branch
2 times, most recently
from
e868c0a to
07d031f
Compare
kinnison
reviewed
Jul 15, 2020
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
It looks consistent, modulo the -gnu failure case we need to resolve, but what's that comment all about?
rbtcollins
force-pushed
the
unit-tests
branch
3 times, most recently
from
2c42bf3 to
86b0459
Compare
Just reporting 'stable' is less clear than we can be, and inconsistent, since a reinstall when a default toolchain has been selected will already report the toolchain desc (via toolchain.name()). Also convert install_sets_up_stable into unit test. This involves making a bunch of test support code available to unit tests, and breaking maybe_install_rust into a calculating part that can be tested, as well as a simple execution part which acts on the calculated result, which we can test separately in functional tests / tests of that underlying layer / integration tests. this_host_triple in addition to being moved has been made somewhat more faithful to from_host_or_build by always returning msvc for windows hosts. Additionally, since it doesn't need to override the BUILD_TRIPLE, that was removed from it.
kinnison
approved these changes
Jul 16, 2020
Contributor
kinnison
left a comment
kinnison
left a comment
There was a problem hiding this comment.
This all seems to make sense.
Contributor
|
You are right that it took quite a kicking from some heavy boots, but I think this is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits please