Consider any comparison with medium changes as probably relevant #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing the latest triage @pnkfelix noted that rust-lang/rust#87736 which yielded this comparison was not included under "probably relevant". This is because previously, we only considered something with only medium and below size changes "probably relevant" if it had either 4 or more medium size changes or if
num_medium_size_changes * 2 + num_small_size_changes > 10which this comparison did not have.This changes the logic such that anything with medium and above size changes are considered at least "probably relevant". It also slightly lowers the threshold for "probably relevant" when there are only small changes down to 8 small changes being considered "probably relevant".