Skip to content

add gpu device side instructions #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2025
Merged

add gpu device side instructions #2524

merged 1 commit into from
Aug 19, 2025

Conversation

ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Jul 29, 2025

WIP, I will develop this along with rust-lang/rust#142696

command:

RUSTFLAGS="-Ctarget-cpu=gfx90a --emit=llvm-ir" cargo +offload build -Zunstable-options -r -v --target amdgcn-amd-amdhsa -Zbuild-std=core

@tshepang
Copy link
Member

tshepang commented Jul 30, 2025

feel free to have these changes on the other side (in the guide subtree, together with the linked pr), to avoid 2 separate reviews

@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Jul 30, 2025

Good to know @tshepang, thanks! In the past I just merged my own PRs here, but if our infra can handle it, I might start doing them together, so my reviewers on the rustc side have an easier time understanding my gpu work.

@ZuseZ4 ZuseZ4 force-pushed the offload-device branch 3 times, most recently from fd2d3d5 to b0c26d1 Compare August 19, 2025 22:39
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Aug 19, 2025

I think these instructions are much to involved for now for any user to follow along, but it's still valuable, either to talk about them with other gpu compiler people, or at the least for me to not forget how to use that code.

Over the next months I will work on reproducing more of the clang infrastructure in rustc, this way we can gradually simplify the instructions here.

@ZuseZ4 ZuseZ4 marked this pull request as ready for review August 19, 2025 22:52
@rustbot
Copy link
Collaborator

rustbot commented Aug 19, 2025

Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using r? rustc-dev-guide or r? <username>.

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 19, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 19, 2025

⚠️ Warning ⚠️

@ZuseZ4 ZuseZ4 merged commit 5587a79 into master Aug 19, 2025
1 check passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 19, 2025
@tshepang tshepang deleted the offload-device branch August 20, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants