Update some out-of-date information #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
the
S-waiting-on-review
camelid
commented
Jan 28, 2021
| **rustc**. Once we are happy with the logical rules, we proceed to | ||
| implementing them in rustc. We map our struct, trait, and impl declarations | ||
| into logical inference rules in the [lowering module in rustc](./lowering-module.md). | ||
| into logical inference rules in the lowering module in rustc. |
There was a problem hiding this comment.
I think this file was removed in #1013.
jyn514
reviewed
Jan 29, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jyn514
added
S-waiting-on-author
|
ping @camelid - will you have time to look at this soon? |
|
Hopefully, yes. |
camelid
commented
Feb 20, 2021
They were removed in rust-lang#1030, but are still useful.
camelid
added
S-waiting-on-review
jyn514
requested changes
Feb 21, 2021
spastorino
added
S-waiting-on-author
|
This looks good, I think after addressing @jyn514 comments is good to go. |
camelid
added
S-waiting-on-review
jyn514
approved these changes
Feb 26, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1040. (And some other stuff.)