Skip to content

Conversation

RalfJung
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 10 commits July 23, 2022 10:15
This commit updates the source_file_to_parser and the
maybe_source_file_to_parse function's doc comments which currently
refer to a config parameter. The doc comments have been updated to
refer to the 'session' parameter similar to the doc comment for
try_file_to_source_file, which also takes a &Session parameter.
…e, r=oli-obk

remove some provenance-related machine hooks that Miri no longer needs

Then we can make `scalar_to_ptr` a method on `Scalar`. :)

Fixes rust-lang/miri#2188
r? `@oli-obk`
Docs - remove unnecessary `mut` that gives a warning

Fixes rust-lang#99654.

A trivial linting fix for a Stdio example.

`@rustbot` label +T-lib
… r=Dylan-DPC

Remove Clean trait implementation for more items

Follow up of rust-lang#99638.

cc `@camelid`
r? `@notriddle`
…nts, r=cjgillot

Update doc comments that refer to config parameter

This commit updates the `source_file_to_parser` and the
`maybe_source_file_to_parse` function's doc comments which currently
refer to a `config` parameter. The doc comments have been updated to
refer to the `session` parameter similar to the doc comment for
`try_file_to_source_file`, which also takes a `&Session` parameter.
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 24, 2022
@RalfJung
Copy link
Member Author

@bors r+ p=5

@bors
Copy link
Collaborator

bors commented Jul 24, 2022

📌 Commit 34d0c0a has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 24, 2022
@bors
Copy link
Collaborator

bors commented Jul 24, 2022

⌛ Testing commit 34d0c0a with merge 7fe022f...

@bors
Copy link
Collaborator

bors commented Jul 24, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 7fe022f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 24, 2022
@bors bors merged commit 7fe022f into rust-lang:master Jul 24, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 24, 2022
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #99687!

Tested on commit 7fe022f.
Direct link to PR: #99687

💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 24, 2022
Tested on commit rust-lang/rust@7fe022f.
Direct link to PR: <rust-lang/rust#99687>

💔 miri on windows: test-fail → build-fail (cc @oli-obk @RalfJung).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7fe022f): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
0.3% 0.3% 1
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-4.2% -4.2% 1
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -4.2% -4.2% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants