Rollup of 5 pull requests #99493
Merged
Rollup of 5 pull requests #99493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually opening a file handle with access set to metadata only will always succeed, even if the file is locked. However some special system files, such as `C:\hiberfil.sys`, are locked by the system in a way that denies even that. So as a fallback we try reading the cached metadata from the directory.
The file it's testing does not exist in the CI environment.
Signed-off-by: Yuki Okushi <[email protected]>
…nding, r=estebank Suggest returning local on "expected `ty`, found `()`" due to expr-less block Putting this up for _initial_ review. Notably, this doesn't consider if the value has possibly been moved, or whether the type is `Copy`. It also provides a structured suggestion if there's one "preferred" binding that matches the type (i.e. one binding in the block or its parent), otherwise it just points them out if there's fewer than 4 of them. Fixes rust-lang#98177 r? `@estebank`
Windows: Use `FindFirstFileW` for getting the metadata of locked system files Fixes rust-lang#96980 Usually opening a file handle with access set to metadata only will always succeed, even if the file is locked. However some special system files, such as `C:\hiberfil.sys`, are locked by the system in a way that denies even that. So as a fallback we try reading the cached metadata from the directory. Note that the test is a bit iffy. I don't know if `hiberfil.sys` actually exists in the CI. r? rust-lang/libs
…ler-errors Erase regions before comparing signatures of foreign fns. Fixes rust-lang#99276 The version with explicit lifetimes is probably tracked in another bug, but I could not find it.
int_macros was only using to_xe_bytes_doc and not from_xe_bytes_doc typo in doc [here](https://doc.rust-lang.org/std/primitive.isize.html#method.from_ne_bytes) "returns" => "takes" `@rustbot` label +T-rustdoc
…rrors Add regression test for rust-lang#71547 Closes rust-lang#71547 r? `@compiler-errors` Signed-off-by: Yuki Okushi <[email protected]>
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (748cb1f): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
ty, found()" due to expr-less block #98784 (Suggest returning local on "expectedty, found()" due to expr-less block)FindFirstFileWfor getting the metadata of locked system files #98916 (Windows: UseFindFirstFileWfor getting the metadata of locked system files)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup