Mention rust-analyzer maintainers when proc_macro bridge is changed
#99183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
lnicola
approved these changes
Jul 12, 2022
Veykril
approved these changes
Jul 12, 2022
|
@bors r+ rollup btw, are we planning to keep the team name "wg-rls-2" indefinitely? I would expect it to change to wg-rls or wg-rust-analyzer at some point. |
bors
added
S-waiting-on-bors
jyn514
added
A-meta
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 13, 2022
…r-a, r=jyn514 Mention rust-analyzer maintainers when `proc_macro` bridge is changed rust-analyzer vendors a modified copy of the `proc_macro` crate in order to expand procedural macros built by Cargo. Since the ABI used by proc macros can change, we need to follow along with those changes. Getting notified when the proc macro bridge changes should make that easier, since that's what defines the ABI. cc ``@rust-lang/wg-rls-2``
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 13, 2022
…r-a, r=jyn514 Mention rust-analyzer maintainers when `proc_macro` bridge is changed rust-analyzer vendors a modified copy of the `proc_macro` crate in order to expand procedural macros built by Cargo. Since the ABI used by proc macros can change, we need to follow along with those changes. Getting notified when the proc macro bridge changes should make that easier, since that's what defines the ABI. cc ````@rust-lang/wg-rls-2````
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 13, 2022
…laumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#98789 (rustdoc-json-types: Clean up derives.) - rust-lang#98848 (Build the Clippy book as part of x.py doc) - rust-lang#99020 (check non_exhaustive attr and private fields for transparent types) - rust-lang#99132 (Add some autolabels for A-bootstrap and T-infra) - rust-lang#99148 (Clarify that [iu]size bounds were only defined for the target arch) - rust-lang#99152 (Use CSS variables to handle theming (part 2)) - rust-lang#99168 (Add regression test for rust-lang#74713) - rust-lang#99176 (:arrow_up: rust-analyzer) - rust-lang#99183 (Mention rust-analyzer maintainers when `proc_macro` bridge is changed) - rust-lang#99185 (llvm-wrapper: adapt for LLVM API change) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 5, 2022
…mention-r-a, r=Mark-Simulacrum Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed" Reverts rust-lang#99183 rust-analyzer is now a subtree, and CI fails when the `proc_macro` bridge changes break our tests, so these notifications aren't needed anymore.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 5, 2022
…mention-r-a, r=Mark-Simulacrum Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed" Reverts rust-lang#99183 rust-analyzer is now a subtree, and CI fails when the `proc_macro` bridge changes break our tests, so these notifications aren't needed anymore.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Sep 5, 2022
…mention-r-a, r=Mark-Simulacrum Revert "Mention rust-analyzer maintainers when `proc_macro` bridge is changed" Reverts rust-lang#99183 rust-analyzer is now a subtree, and CI fails when the `proc_macro` bridge changes break our tests, so these notifications aren't needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-analyzer vendors a modified copy of the
proc_macrocrate in order to expand procedural macros built by Cargo. Since the ABI used by proc macros can change, we need to follow along with those changes. Getting notified when the proc macro bridge changes should make that easier, since that's what defines the ABI.cc @rust-lang/wg-rls-2