Skip to content

Avoid some &str to String conversions #99103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2022
Merged

Avoid some &str to String conversions #99103

merged 1 commit into from
Jul 10, 2022

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Jul 10, 2022

This patch removes some &str to String conversions.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 10, 2022
@rustbot
Copy link
Collaborator

rustbot commented Jul 10, 2022

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Jul 10, 2022

r? @oli-obk

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 10, 2022

📌 Commit bda83e6 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 10, 2022
@bors
Auto merge of rust-lang#99112 - matthiaskrgr:rollup-uv2zk4d, r=matthi…
268be96 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#99045 (improve print styles)
 - rust-lang#99086 (Fix display of search result crate filter dropdown)
 - rust-lang#99100 (Fix binary name in help message for test binaries)
 - rust-lang#99103 (Avoid some `&str` to `String` conversions)
 - rust-lang#99109 (fill new tracking issue for `feature(strict_provenance_atomic_ptr)`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 86af713 into rust-lang:master Jul 10, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 10, 2022
@TaKO8Ki TaKO8Ki deleted the avoid-&str-to-string-conversions branch July 11, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@TaKO8Ki @rustbot @rust-highfive @oli-obk @bors @petrochenkov