Rollup of 6 pull requests #98910
Merged
Rollup of 6 pull requests #98910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They never return `None`, so they trivially fulfill the contract.
Co-authored-by: Joe ST <[email protected]>
a lot of the `&`s and `ref`s were redundant
Implement `FusedIterator` for `std::net::[Into]Incoming` They never return `None`, so they trivially fulfill the contract. What should I put for the stability attribute of `Incoming`?
more `need_type_info` improvements this now deals with macros in suggestions and the source cost computation does what I want for `channel` 🎉 r? ``@estebank``
…li-obk Interpret: AllocRange Debug impl, and use it more consistently The two commits are pretty independent but it did not seem worth having two PRs for them. r? ``@oli-obk``
fix interpreter validity check on Box Follow-up to rust-lang#98554: avoid walking over parts of the value twice. And then move all that logic into the general visitor so not each visitor implementation has to deal with it...
…orrowing, r=oli-obk clean up the borrowing in rustc_hir_pretty A whole lot of the `&`s and `ref`s were redundant. I hope doing this in one big commit is fine, because all of the changes are pretty self-contained. `@rustbot` label: +C-cleanup
…num-with-default-attribute, r=fee1-dead Suggest `#[derive(Default)]` to enums with `#[default]` fixes rust-lang#95226
rustbot
added
T-compiler
|
@bors r+ rollup=never p=5 |
|
📌 Commit 9a2274c has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 5, 2022
Tested on commit rust-lang/rust@4045ce6. Direct link to PR: <rust-lang/rust#98910> 💔 miri on windows: test-pass → build-fail (cc @oli-obk @RalfJung). 💔 miri on linux: test-pass → build-fail (cc @oli-obk @RalfJung).
This was referenced Jul 5, 2022
Merged
|
Finished benchmarking commit (4045ce6): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
FusedIteratorforstd::net::[Into]Incoming#97300 (ImplementFusedIteratorforstd::net::[Into]Incoming)need_type_infoimprovements #98761 (moreneed_type_infoimprovements)#[derive(Default)]to enums with#[default]#98873 (Suggest#[derive(Default)]to enums with#[default])Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup