Skip to content

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Jul 1, 2022

#96630 was tagged relnotes but didn't make it into the notes. Given this is a compatibility issue (#97030, #98735, #98743), it probably should be retroactively added.

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 1, 2022
@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jul 1, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 1, 2022

cc @notriddle

@jyn514
Copy link
Member

jyn514 commented Jul 1, 2022

@Mark-Simulacrum will want you to squash the commits into one. r=me after that (use @bors r=jyn514 rollup).

@bors delegate=CAD97

@jyn514

This comment was marked as outdated.

@jyn514 jyn514 closed this Jul 1, 2022
@bors
Copy link
Collaborator

bors commented Jul 1, 2022

✌️ @ can now approve this pull request

@jyn514 jyn514 reopened this Jul 1, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 1, 2022

@bors delegate=@CAD97

@bors
Copy link
Collaborator

bors commented Jul 1, 2022

✌️ @CAD97 can now approve this pull request

@CAD97
Copy link
Contributor Author

CAD97 commented Jul 1, 2022

@bors r=Mark-Simulacrum rollup

@bors
Copy link
Collaborator

bors commented Jul 1, 2022

📌 Commit ab437ad5e46db30f1dc08d21cd73f9ef9ffa13b5 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2022
@CAD97
Copy link
Contributor Author

CAD97 commented Jul 1, 2022

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 1, 2022
@CAD97
Copy link
Contributor Author

CAD97 commented Jul 1, 2022

Sorry didn't read one moment 🙃

@CAD97
Copy link
Contributor Author

CAD97 commented Jul 1, 2022

@bors r=jyn514 rollup

@bors
Copy link
Collaborator

bors commented Jul 1, 2022

📌 Commit 4ea18cc has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 1, 2022
…askrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#98610 (fix `emit_inference_failure_err` ICE)
 - rust-lang#98640 (Let rust-analyzer ship on stable, non-preview)
 - rust-lang#98686 (add ice test for 46511)
 - rust-lang#98727 (rustdoc: filter '_ lifetimes from ty::PolyTraitRef)
 - rust-lang#98729 (clarify that ExactSizeIterator::len returns the remaining length)
 - rust-lang#98733 (Request to be notified of MIR changes)
 - rust-lang#98734 (Update RELEASES.md)
 - rust-lang#98745 (Add a `--build-dir` flag to rustbuild)
 - rust-lang#98749 (Add macro_rules! rustdoc change to 1.62 relnotes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 18d4228 into rust-lang:master Jul 1, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 1, 2022
@CAD97 CAD97 deleted the patch-3 branch July 14, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants