validating the vtable can lead to Stacked Borrows errors #97761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
rustbot
added
the
T-compiler
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
RalfJung
force-pushed
the
vtable-validation
branch
from
5f5a3bc to
67ec969
Compare
|
IIUC, this fixes a miri ICE, and the worst that could happen is a weird diagnostic if the assumption is wrong. |
|
📌 Commit 67ec969 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 11, 2022
validating the vtable can lead to Stacked Borrows errors Fixes rust-lang/miri#2123
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97761 (validating the vtable can lead to Stacked Borrows errors) - rust-lang#97789 (Fix rust-lang#71363's test by adding `-Z translate-remapped-path-to-local-path=no`) - rust-lang#97913 (Wrap `HirId`s of locals into `LocalVarId`s for THIR nodes) - rust-lang#97979 (Fix typos in Provider API docs) - rust-lang#97987 (remove an unnecessary `String`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jun 12, 2022
test for Stacked Borrows error during vtable validation Fixes #2123 Needs rust-lang/rust#97761
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Jun 12, 2022
test for Stacked Borrows error during vtable validation Fixes #2123 Needs rust-lang/rust#97761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/miri#2123