-
Couldn't load subscription status.
- Fork 13.9k
[beta] Beta backports #97631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta] Beta backports #97631
Conversation
…enkov Allow the unused_macro_rules lint for now It was newly added by rust-lang#96150 with warn by default, which is great as it gave exposure to the community, and their feedback gave me ideas for improvements. Allowing the lint is good for two reasons: * It makes the transition easier as e.g. allow directives won't fire the unknown lint warning once it is turned to warn by default in the future. The [commit that allowed the lint in fuchsia](https://fuchsia.googlesource.com/fuchsia/+/9d8f96517c3963de2f0e25598fd36061914524cd%5E%21/) had to allow unknown lints for example. This is especially important compared to other lints in the unused group, because the _ prefix trick doesn't exist for macro rules, allowing is the only option (either of unused_macro_rules, or of the entire unused group, but that is not as informative to readers). Allowing the lint also makes it possible to work on possible heuristics for disabling the macro in specific cases. * It gives time for implementing heuristics for when to suppress the lint, e.g. when `compile_error!` is invoked by that arm (so it's only there to yield an error). See: rust-lang#96150 (comment) I would also like this to be backported to the 1.62 beta branch (cc rust-lang#97016).
Fix some typos in arg checking algorithm Fixes rust-lang#97197 Also fixes a typo where if we're missing args A, B, C, we actually say A, B, B
…rister rustc: Fix ICE in native library error reporting Fixes rust-lang#97299
|
|
@bors r+ rollup=never |
|
📌 Commit 054a2bd has been approved by |
|
@bors r- |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors r+ rollup=never |
|
📌 Commit 054a2bd has been approved by |
|
☀️ Test successful - checks-actions |
cargo publish -p spec[beta] Backportcargo publishfixes cargo#10707