ptr::invalid is not equivalent to a int2ptr cast #97482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
r? @thomcc (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 852777e has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 28, 2022
ptr::invalid is not equivalent to a int2ptr cast I just realized I forgot to update these docs when adding `from_exposed_addr`. Right now the docs say `invalid` and `from_exposed_addr` are both equivalent to a cast, and that is clearly not what we want. Cc `@Gankra`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2022
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#96950 (Add regression test for rust-lang#96395) - rust-lang#97028 (Add support for embedding pretty printers via `#[debugger_visualizer]` attribute) - rust-lang#97478 (Remove FIXME on `ExtCtxt::fn_decl()`) - rust-lang#97479 (Make some tests check-pass) - rust-lang#97482 (ptr::invalid is not equivalent to a int2ptr cast) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized I forgot to update these docs when adding
from_exposed_addr.Right now the docs say
invalidandfrom_exposed_addrare both equivalent to a cast, and that is clearly not what we want (and is also not the case any more in terms of implementation since #97219).Cc @Gankra