Make hir().get_generics and generics_of consistent. #97446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors r=michaelwoerister rollup |
|
📌 Commit f191a65ec4a546ff12949d95273c462a0e007494 has been approved by |
bors
added
S-waiting-on-bors
This was referenced Jun 3, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2022
Rollup of 3 pull requests Successful merges: - rust-lang#97415 (Compute `is_late_bound_map` query separately from lifetime resolution) - rust-lang#97471 (Provide more context when denying invalid type params ) - rust-lang#97681 (Add more eslint checks) Failed merges: - rust-lang#97446 (Make hir().get_generics and generics_of consistent.) r? `@ghost` `@rustbot` modify labels: rollup
|
☔ The latest upstream changes (presumably #97694) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
|
@bors r=michaelwoerister rollup |
|
📌 Commit 623ea5f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 4, 2022
…askrgr Rollup of 5 pull requests Successful merges: - rust-lang#97446 (Make hir().get_generics and generics_of consistent.) - rust-lang#97656 (Add a suggestion to replace parentheses with angle brackets on associated trait constraint) - rust-lang#97692 (Add `#T-types/nominated` zulip notification) - rust-lang#97696 (Do not ICE when failing to normalize during inlining.) - rust-lang#97702 (Remove useless LocalDefId in ImplTraitContext::Universal.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching generics from a HIR node is currently implemented differently in 4 different places.
This PR makes the 4 implementations call the single
hir::Node::generics, which implements the more general version fromgenerics_ofquery.