Stabilize const_ptr_read #97320

usbalbin · 2022-05-23T16:32:24Z

Stabilizes const_ptr_read, with tracking issue #80377

rust-highfive · 2022-05-23T16:32:27Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-05-23T16:32:28Z

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2022-05-27T18:39:36Z

r? @m-ou-se for T-libs-api FCP (maybe on the tracking issue, not sure)

bors · 2022-07-01T23:04:27Z

☔ The latest upstream changes (presumably #93967) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2022-07-02T20:36:44Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

apiraino · 2022-07-06T13:27:24Z

Removing T-compiler since I think these changes are of interest only for T-libs-api (but if it's not the case feel free to re-add the add and ask for a review).

@rustbot label -T-compiler

bors · 2022-07-24T09:38:19Z

☔ The latest upstream changes (presumably #98674) made this pull request unmergeable. Please resolve the merge conflicts.

est31 · 2022-08-27T20:18:18Z

👋 Hello, I'm writing this comment in this stabilization PR to notify you, the authors of this PR, that #100591 has been merged, which implemented a change in how features are stabilized.

Your PR has been filed before the change, so will likely require modifications in order to comply with the new rules. I recommend you to:

rebase the PR onto latest master, so that uses of the placeholder are possible.
replace the version numbers in the PR with the placeholder CURRENT_RUSTC_VERSION. For language changes, this means the version numbers in accepted.rs (example: 4caedba). For library changes, this means the since fields (example e576a9b).

That's it! The CURRENT_RUSTC_VERSION placeholder will, as part of the release process, be replaced with the version number that the PR merged for. It can be used anywhere in rust-lang/rust, not just accepted.rs and the since fields.

If you have any questions, feel free to drop by the zulip stream, or ping me directly in this PR's thread. Thanks! 👋

pitaj · 2023-05-05T02:36:58Z

@usbalbin FYI you have merge conflicts. Please fix those so this PR can be merged, now that the FCP is complete.

oli-obk · 2023-05-05T09:03:11Z

@rustbot author

rustbot · 2023-05-05T17:35:36Z

The Miri subtree was changed

cc @rust-lang/miri

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

usbalbin · 2023-05-05T17:38:26Z

The Miri subtree was changed

cc @rust-lang/miri

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged. Otherwise, you can ignore this comment.

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

How do I undo that?

pitaj · 2023-05-05T18:03:54Z

I think that message is a false positive, your only miri changes are to tests and Cargo.lock was not changed.

@rustbot ready

saethlin · 2023-05-05T18:28:11Z

The message is not a false positive, but it's also not supposed to be an indication that you shouldn't do what you're doing. Your change to the Miri subtree is good (assuming tests pass).

m-ou-se · 2023-05-09T15:05:26Z

FCP completed here

@bors r+

bors · 2023-05-09T15:05:28Z

📌 Commit 81c2459 has been approved by m-ou-se

It is now in the queue for this repository.

bors · 2023-05-09T15:05:29Z

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

…r=m-ou-se Stabilize const_ptr_read Stabilizes const_ptr_read, with tracking issue rust-lang#80377

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#97320 (Stabilize const_ptr_read) - rust-lang#110770 (Limit lifetime of format_args!() with inlined args.) - rust-lang#111021 (Move some tests) - rust-lang#111215 (Various changes to name resolution of anon consts) - rust-lang#111242 (support set `rpath` option for each target independently) - rust-lang#111282 (Remove some `assume`s from slice iterators that don't do anything) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

usbalbin · 2023-05-09T21:56:29Z

Thank you :)

rust-highfive assigned Mark-Simulacrum May 23, 2022

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 23, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 23, 2022

This comment has been minimized.

Sign in to view

usbalbin force-pushed the stabilize_const_ptr_read branch 2 times, most recently from ffee3f8 to 2e087f9 Compare May 23, 2022 16:59

This comment has been minimized.

Sign in to view

usbalbin force-pushed the stabilize_const_ptr_read branch from 2e087f9 to c864425 Compare May 23, 2022 18:49

This comment has been minimized.

Sign in to view

usbalbin force-pushed the stabilize_const_ptr_read branch from c864425 to 91cd111 Compare May 24, 2022 16:07

usbalbin mentioned this pull request May 24, 2022

Tracking Issue for const_ptr_read #80377

Closed

3 tasks

usbalbin force-pushed the stabilize_const_ptr_read branch 2 times, most recently from b28eb19 to b637419 Compare May 24, 2022 16:35

This comment has been minimized.

Sign in to view

usbalbin force-pushed the stabilize_const_ptr_read branch from b637419 to b92fb7f Compare May 24, 2022 17:54

usbalbin marked this pull request as ready for review May 24, 2022 18:35

rust-highfive assigned m-ou-se and unassigned Mark-Simulacrum May 27, 2022

usbalbin force-pushed the stabilize_const_ptr_read branch from b92fb7f to 414638e Compare July 2, 2022 20:36

rustbot removed the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 6, 2022

usbalbin force-pushed the stabilize_const_ptr_read branch from 414638e to d2d2538 Compare August 27, 2022 23:29

pitaj added disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. labels May 5, 2023

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2023

usbalbin force-pushed the stabilize_const_ptr_read branch from 882622d to 8855f20 Compare May 5, 2023 17:35

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 5, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 5, 2023

Stabilize const_ptr_read

81c2459

usbalbin force-pushed the stabilize_const_ptr_read branch from 8855f20 to 81c2459 Compare May 5, 2023 18:37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 9, 2023

Rollup merge of rust-lang#97320 - usbalbin:stabilize_const_ptr_read, …

8488f24

…r=m-ou-se Stabilize const_ptr_read Stabilizes const_ptr_read, with tracking issue rust-lang#80377

matthiaskrgr mentioned this pull request May 9, 2023

Rollup of 6 pull requests #111392

Closed

matthiaskrgr mentioned this pull request May 9, 2023

Rollup of 6 pull requests #111402

Merged

bors merged commit 88fbfaf into rust-lang:master May 9, 2023

rustbot added this to the 1.71.0 milestone May 9, 2023

Stabilize const_ptr_read #97320

Stabilize const_ptr_read #97320

Uh oh!

Conversation

usbalbin commented May 23, 2022 • edited by thomcc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented May 23, 2022

Uh oh!

rust-highfive commented May 23, 2022

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Mark-Simulacrum commented May 27, 2022

Uh oh!

bors commented Jul 1, 2022

Uh oh!

rustbot commented Jul 2, 2022

Uh oh!

apiraino commented Jul 6, 2022

Uh oh!

bors commented Jul 24, 2022

Uh oh!

est31 commented Aug 27, 2022

Uh oh!

pitaj commented May 5, 2023

Uh oh!

oli-obk commented May 5, 2023

Uh oh!

rustbot commented May 5, 2023

Uh oh!

usbalbin commented May 5, 2023

Uh oh!

pitaj commented May 5, 2023

Uh oh!

saethlin commented May 5, 2023

Uh oh!

m-ou-se commented May 9, 2023

Uh oh!

bors commented May 9, 2023

Uh oh!

bors commented May 9, 2023

Uh oh!

usbalbin commented May 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

usbalbin commented May 23, 2022 •

edited by thomcc

Loading

usbalbin commented May 9, 2023 •

edited

Loading