Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

cc @yaahc, who found this while testing locally

Ideally we'd detect this in CI and catch it, but at least we have a comment now which should hopefully prevent this from happening in the future.

r? @pietroalbini or @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2022
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have r+ rights, but lgtm

@Mark-Simulacrum
Copy link
Member Author

@bors r=jyn514

@bors
Copy link
Collaborator

bors commented May 21, 2022

📌 Commit 7501995 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2022
@pietroalbini
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request May 21, 2022
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#97190 (Add implicit call to from_str via parse in documentation)
 - rust-lang#97218 (Add eslint checks)
 - rust-lang#97219 (make ptr::invalid not the same as a regular int2ptr cast)
 - rust-lang#97223 (Remove quadratic behaviour from -Zunpretty=hir-tree.)
 - rust-lang#97232 (typo)
 - rust-lang#97237 (Add some more weird-exprs)
 - rust-lang#97238 (Bump LLVM fetched from CI to fix run-make)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 28730ac into rust-lang:master May 21, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants