Skip to content

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented May 12, 2022

20 commits in a44758ac805600edbb6ba51e7e6fb81a6077c0cd..3f052d8eed98c6a24f8b332fb2e6e6249d12d8c1
2022-05-04 02:29:34 +0000 to 2022-05-12 15:19:04 +0000

@ehuss ehuss self-assigned this May 12, 2022
@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2022
@ehuss
Copy link
Contributor Author

ehuss commented May 12, 2022

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented May 12, 2022

📌 Commit e353579 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2022
@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Testing commit e353579 with merge 757c12d56581a8f94e1b2a02e57224f6c109a17a...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ehuss
Copy link
Contributor Author

ehuss commented May 12, 2022

@bors retry

dist-aarch64-apple

The hosted runner: GitHub Actions 6 lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@bors
Copy link
Collaborator

bors commented May 12, 2022

⌛ Testing commit e353579 with merge a5ad0d2...

@bors
Copy link
Collaborator

bors commented May 12, 2022

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing a5ad0d2 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 12, 2022
@bors bors merged commit a5ad0d2 into rust-lang:master May 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 12, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a5ad0d2): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.
Warning ⚠: The following benchmark(s) failed to build:

  • rustc

@rustbot label: -perf-regression

@lqd
Copy link
Member

lqd commented May 14, 2022

It was noticed in this zulip thread that this PR apparently broke the rustc benchmark, I'm not sure why.

cc author @ehuss, and @rust-lang/wg-compiler-performance

@ehuss
Copy link
Contributor Author

ehuss commented May 14, 2022

cc @Urgau

These lines need to pass different flags based on which cargo is being used. I suggest just disabling them until the beta bump which should happen in a couple weeks.

bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants