- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Fix js error #96900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Fix js error #96900
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Some changes occurred in HTML/CSS/JS. | 
| I opened #96902 about adding a check for JS errors. | 
| @bors r+ rollup | 
| 📌 Commit fe4fa53 has been approved by  | 
    
  matthiaskrgr 
      added a commit
        to matthiaskrgr/rust
      that referenced
      this pull request
    
      May 10, 2022 
    
    
      
  
    
      
    
  
…iddle Fix js error On the source code pages, we get a JS error:  It's fixed in the first commit. The second one is removing an unused CSS rule and the third one is a little cleanup of a GUI test. cc `@jsha` r? `@notriddle`
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      May 11, 2022 
    
    
      
  
    
      
    
  
Rollup of 7 pull requests Successful merges: - rust-lang#96543 (Remove hacks in `make_token_stream`.) - rust-lang#96887 (rustdoc: correct path to type alias methods) - rust-lang#96896 (Add regression test for rust-lang#68408) - rust-lang#96900 (Fix js error) - rust-lang#96903 (Use lifetimes on type-alias-impl-trait used in function signatures to infer output type lifetimes) - rust-lang#96916 (simplify length count) - rust-lang#96925 (Fix issue rust-lang#95151) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    A-doctests
  Area: Documentation tests, run by rustdoc 
  
    A-rustdoc-js
  Area: Rustdoc's JS front-end 
  
    A-rustdoc-ui
  Area: Rustdoc UI (generated HTML) 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-rustdoc
  Relevant to the rustdoc team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
On the source code pages, we get a JS error:
It's fixed in the first commit. The second one is removing an unused CSS rule and the third one is a little cleanup of a GUI test.
cc @jsha
r? @notriddle