Mitigate impact of subtle invalid call suggestion logic #96646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
There's some subtle interaction between inferred expressions being passed as an argument to fn calls with fewer than expected arguments. To avoid the ICE, I'm changing indexing operations with `.get(idx)`, but the underlying logic still needs to be audited as it was written with the assumption that `final_arg_types` and `provided_args` have the right length. Address 96638.
|
r=me, but I wonder if we should see if someone wants to fix the root cause of the issue soon/first? I definitely think that if this lands, it should be reverted along with the actual fix for #96638 |
|
📌 Commit 7790b6e has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 2, 2022
Mitigate impact of subtle invalid call suggestion logic There's some subtle interaction between inferred expressions being passed as an argument to fn calls with fewer than expected arguments. To avoid the ICE, I'm changing indexing operations with `.get(idx)`, but the underlying logic still needs to be audited as it was written with the assumption that `final_arg_types` and `provided_args` have the right length. Address rust-lang#96638.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 3, 2022
Rollup of 8 pull requests Successful merges: - rust-lang#93097 (Switch settings menu to full js) - rust-lang#96587 (Refactor the WriteBackendMethods and ExtraBackendMethods traits) - rust-lang#96589 (Use source callsite in check_argument_types suggestion) - rust-lang#96599 (Update `RValue::Discriminant` documentation) - rust-lang#96614 (Add a regression test for rust-lang#92305) - rust-lang#96629 (Fix invalid keyword order for function declarations) - rust-lang#96641 (Use a yes/no enum instead of a bool.) - rust-lang#96646 (Mitigate impact of subtle invalid call suggestion logic) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some subtle interaction between inferred expressions being
passed as an argument to fn calls with fewer than expected arguments. To
avoid the ICE, I'm changing indexing operations with
.get(idx), butthe underlying logic still needs to be audited as it was written with
the assumption that
final_arg_typesandprovided_argshave the rightlength.
Address #96638.