Skip to content

Conversation

c410-f3r
Copy link
Contributor

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 24, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2022
@petrochenkov
Copy link
Contributor

issue-45696-no-variant-box-recur.rs -> nll
issue-17233.rs -> statics
issue-26545.rs -> resolve
issue-3820.rs -> binop
issue-72574-1.rs -> pattern
issue-25339.rs -> associated-types
issue-55846.rs -> associated-types

How were the subdirectories chosen?
Unlike with the previous PRs I found classifui to give better suggestions in nearly all the cases.
issue-25339.rs in particular doesn't even use the crate keyword!

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2022
@c410-f3r
Copy link
Contributor Author

All chosen by me after getting weird suggestions

Capture d’écran de 2022-04-25 13-07-30

I could swear I trained the dataset. Well... Maybe not, I don't remember anymore.

@c410-f3r
Copy link
Contributor Author

issue-45696-no-variant-box-recur.rs -> nll issue-17233.rs -> statics issue-26545.rs -> resolve issue-3820.rs -> binop issue-72574-1.rs -> pattern issue-25339.rs -> associated-types issue-55846.rs -> associated-types

How were the subdirectories chosen? Unlike with the previous PRs I found classifui to give better suggestions in nearly all the cases. issue-25339.rs in particular doesn't even use the crate keyword!

Done

@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 27, 2022
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 27, 2022

📌 Commit b72f6e5 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 27, 2022
@bors
Copy link
Collaborator

bors commented Apr 27, 2022

⌛ Testing commit b72f6e5 with merge 2799141...

@bors
Copy link
Collaborator

bors commented Apr 27, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 2799141 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 27, 2022
@bors bors merged commit 2799141 into rust-lang:master Apr 27, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 27, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2799141): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants