Skip to content

Refactor loop into iterator; simplify negation logic. #96029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Refactor loop into iterator; simplify negation logic. #96029

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53b2aca
Refactor loop into iterator; simplify negation logic.
IsakNyberg Apr 13, 2022
657ae03
Update compiler/rustc_error_messages/src/lib.rs
IsakNyberg Apr 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions compiler/rustc_error_messages/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,18 +320,12 @@ impl MultiSpan {

/// Returns `true` if any of the primary spans are displayable.
pub fn has_primary_spans(&self) -> bool {
self.primary_spans.iter().any(|sp| !sp.is_dummy())
!self.is_dummy()
}

/// Returns `true` if this contains only a dummy primary span with any hygienic context.
pub fn is_dummy(&self) -> bool {
let mut is_dummy = true;
for span in &self.primary_spans {
if !span.is_dummy() {
is_dummy = false;
}
}
is_dummy
self.primary_spans.iter().all(|sp| sp.is_dummy())
}

/// Replaces all occurrences of one Span with another. Used to move `Span`s in areas that don't
Expand Down