Fix multiline attributes handling in doctests #95590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-compiler
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
notriddle
approved these changes
Apr 2, 2022
GuillaumeGomez
force-pushed
the
multi-line-attr-handling-doctest
branch
from
560aa07 to
6fa5740
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
multi-line-attr-handling-doctest
branch
from
6fa5740 to
b135b02
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
multi-line-attr-handling-doctest
branch
from
b135b02 to
732ed2a
Compare
|
Finally added all missing options for the UI test to work both locally and remotely. ^^' @bors: r=notriddle |
|
📌 Commit 732ed2a has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (c1550e3): comparison url. Summary: This benchmark run did not return any relevant results. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55713.
I needed to have access to the
unclosed_delimsfield in order to check that the attribute was completely parsed and didn't have missing parts, so I created a getter for it.r? @notriddle