Skip to content

Add note to the move size diagnostic #95478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

Add note to the move size diagnostic #95478

merged 1 commit into from
Mar 31, 2022

Conversation

b-NC
Copy link
Contributor

@b-NC b-NC commented Mar 30, 2022 •
edited by Dylan-DPC
Loading

context: #83518

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 30, 2022
@rust-highfive
Copy link
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2022
@b-NC
Copy link
Contributor Author

b-NC commented Mar 30, 2022 •
edited
Loading

Resolves one tick on #83518

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@b-NC
Copy link
Contributor Author

b-NC commented Mar 30, 2022

@Dylan-DPC Sorry, I don't understand why you edited this PR's description

compiler-errors
compiler-errors reviewed Mar 30, 2022
View reviewed changes
@compiler-errors
Copy link
Member

Can you bless the tests again? -- CI is going to fail since stderr is not updated on those. And please squash the commits into one, thanks!

compiler-errors
compiler-errors reviewed Mar 30, 2022
View reviewed changes
@b-NC
Copy link
Contributor Author

b-NC commented Mar 30, 2022

Can you bless the tests again? -- CI is going to fail since stderr is not updated on those. And please squash the commits into one, thanks!

The entirety of the commits or just these two ?

@compiler-errors
Copy link
Member

compiler-errors commented Mar 30, 2022 •
edited
Loading

All of them, please. No need to have 5 commits for a PR that changes 3 files 😆 Thanks!

@compiler-errors
Copy link
Member

Thanks a bunch.

r? @compiler-errors
@bors r+ rollup=always

@bors
Copy link
Collaborator

bors commented Mar 30, 2022

📌 Commit d65b9a1 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2022
@Dylan-DPC
Copy link
Member

@Dylan-DPC Sorry, I don't understand why you edited this PR's description

Just added the issue number to the top comment so it's easier to view in future

@Dylan-DPC Dylan-DPC mentioned this pull request Mar 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2022
@bors
Auto merge of rust-lang#95511 - Dylan-DPC:rollup-4n880fd, r=Dylan-DPC
0331491 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95445 (Don't build the full compiler before running unit tests)
 - rust-lang#95470 (Fix last rustdoc-gui spurious test)
 - rust-lang#95478 (Add note to the move size diagnostic)
 - rust-lang#95495 (Remove unneeded `to_string` call)
 - rust-lang#95505 (Fix library/std compilation on openbsd.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4388ac5 into rust-lang:master Mar 31, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 31, 2022
@b-NC b-NC mentioned this pull request Apr 2, 2022
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.
8 participants
@b-NC @rust-highfive @rust-log-analyzer @compiler-errors @bors @Dylan-DPC @nagisa @rustbot