update CPU usage script #95446
update CPU usage script #95446
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
src/etc/cpu-usage-over-time-plot.sh
Outdated
| set -ex | ||
|
|
||
| bucket=rust-lang-ci2 | ||
| commit=$1 | ||
| builder=$2 | ||
|
|
||
| curl -O https://$bucket.s3.amazonaws.com/rustc-builds/$commit/cpu-$builder.csv | ||
| curl -O https://$bucket.s3.amazonaws.com/rustc-builds-alt/$commit/cpu-dist-$builder.csv |
There was a problem hiding this comment.
This probably shouldn't be changing to -alt, those are less typically queried than regular builders.
src/etc/cpu-usage-over-time-plot.sh
Outdated
| @@ -14,13 +14,19 @@ | |||
| # | |||
| # Improvements to this script are greatly appreciated! | |||
|
|
|||
| if [[ $# != 2 ]]; then | |||
| echo "expected 2 arguments, recieved $#" | |||
| echo "example usage: './src/etc/cpu-usage-over-time-plot.sh 0003d1a38d97b12a389bd1e5b49f9db92094ee4a x86_64-linux-alt'" | |||
There was a problem hiding this comment.
A non-alt builder name is probably better here.
src/etc/cpu-usage-over-time-plot.sh
Outdated
| set -ex | ||
|
|
||
| bucket=rust-lang-ci2 | ||
| commit=$1 | ||
| builder=$2 | ||
|
|
||
| curl -O https://$bucket.s3.amazonaws.com/rustc-builds/$commit/cpu-$builder.csv | ||
| curl -O https://$bucket.s3.amazonaws.com/rustc-builds-alt/$commit/cpu-dist-$builder.csv |
There was a problem hiding this comment.
Is there a change that made these files cpu-dist-$name? I believe this script did work with just cpu-$builder, so I'm a little confused.
Mark-Simulacrum
added
S-waiting-on-author
|
Ping from triage: |
|
I made incorrect assumptions about cpu-$name being changed to cpu-dist-$name and -alt. I apologize as I did a poor job of checking things, sorry for any wasted time. |
apiraino
added
the
T-infra
|
triage: looks like this was ready for review but wasn't placed in review state. |
rustbot
added
S-waiting-on-review
|
r=me with commits squashed into one |
|
my mistake @notseanray can you please squash the commits and then change to Waitingo-on-review with |
rustbot
added
S-waiting-on-author
fix tidy checks and correct cpu-usage-over-time-plot script
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 8eb7ddf has been approved by |
bors
added
S-waiting-on-bors
update CPU usage script I've made slight changes to the CPU usage plot script with updated links from the [ci2 aws instance](https://rust-lang-ci2.s3.amazonaws.com/).
Rollup of 10 pull requests Successful merges: - rust-lang#95446 (update CPU usage script) - rust-lang#96768 (Use futex based thread parker on Fuchsia.) - rust-lang#97454 (Add release notes for 1.62) - rust-lang#97516 (clarify how Rust atomics correspond to C++ atomics) - rust-lang#97818 (Point at return expression for RPIT-related error) - rust-lang#97895 (Simplify `likely!` and `unlikely!` macro) - rust-lang#98005 (Add some tests for impossible bounds) - rust-lang#98226 (Document unstable `--extern` options) - rust-lang#98356 (Add missing period) - rust-lang#98363 (remove use of &Alloc in btree tests) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
I've made slight changes to the CPU usage plot script with updated links from the ci2 aws instance.